Skip to content

chore: cd workflow#3935

Open
d-v-b wants to merge 4 commits intozarr-developers:mainfrom
d-v-b:chore/publish-metadata-package
Open

chore: cd workflow#3935
d-v-b wants to merge 4 commits intozarr-developers:mainfrom
d-v-b:chore/publish-metadata-package

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented May 2, 2026

this adds a cd workflow for zarr-metadata

we either publish to pypi, in which case the version declared in the package is used, or we publish to testpypi, in which case a synthetic, unique version is created to ensure that we never have a conflict on testpypi.

this workflow only supports workflow dispatch right now. later PRs will add a tag-based release workflow.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (80d45ca) to head (44cb295).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3935   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          87       87           
  Lines       11696    11696           
=======================================
  Hits        10905    10905           
  Misses        791      791           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b requested review from ilan-gold and maxrjones May 2, 2026 15:17
@ilan-gold
Copy link
Copy Markdown
Contributor

If I understand this right here, we can get rid of this "make a unique version script" since the version should be unqiuely identified by a commit and it doesn't really make sense to run this twice on the same commit

@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented May 6, 2026

@ilan-gold good point, that script is now gone

@ilan-gold
Copy link
Copy Markdown
Contributor

ilan-gold commented May 6, 2026

Ok so my comment here was right. My above comment assumes you are using hatch-vcs. Would you be interested in that @d-v-b? I could apply it to both this and the top-level package since we seem to be using hatch here.

@ilan-gold
Copy link
Copy Markdown
Contributor

I become so used to our own dev setup, I forget what doesn't happen by default!

@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented May 6, 2026

Ok so my comment here was right. My above comment assumes you are using hatch-vcs. Would you be interested in that @d-v-b? I could apply it to both this and the top-level package since we seem to be using hatch here.

Yes, vcs versioning for zarr metadata would be great! I think we can define a regex that matches git tags like zarr-metadata/<version>

@ilan-gold
Copy link
Copy Markdown
Contributor

Ok will have a look in the morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants